-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support ROS Melodic #514
Support ROS Melodic #514
Conversation
Note that the melodic CI build will fail until ros/rosdistro#17809 is merged and the package has been built on the build farm. |
@@ -4,14 +4,14 @@ marti\_common [![Build Status](https://travis-ci.org/swri-robotics/marti_common. | |||
|
|||
This repository provides various utility packages created at [Southwest Reseach Institute](http://www.swri.org)'s [Intelligent Vehicle Systems](http://www.swri.org/4org/d10/isd/ivs/default.htm) section for working with [Robot Operating System(ROS)](http://www.ros.org). | |||
|
|||
Installation (ROS Indigo, Jade, Kinetic, Lunar) | |||
Installation (ROS Indigo, Kinetic, Lunar, Melodic) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You could have kept Jade in there, unless OSRF is no longer hosting the repo.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think they're still hosting it, but it's been past EOL for a year now, they're no longer accepting releases into it, and I'm not planning to fix it if something breaks. I didn't want to give a misleading impression that we were still supporting it, although I suppose it's not a big deal either way. Do you think it's worth leaving in there?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤷♂️
@@ -64,7 +64,11 @@ namespace swri_opencv_util | |||
} | |||
} | |||
|
|||
#if (BOOST_VERSION / 100 % 1000) >= 65 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh wow this is actually the supported way of detecting the boost version. Eww.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, that's the same face I made. Oh, boost.
Ubuntu 18.04 comes with boost 1.65.1, and the usage of the
boost::serialization::singleton
class changed slightly in it (see https://www.boost.org/doc/libs/1_65_0/libs/serialization/doc/singleton.html ). This will make marti_common compile properly on 18.04 / Melodic.